-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Repo for Compatibility w/ DANDI #28
Updated Repo for Compatibility w/ DANDI #28
Conversation
src/datta_lab_to_nwb/markowitz_gillis_nature_2023/markowitz_gillis_nature_2023_metadata.yaml
Outdated
Show resolved
Hide resolved
src/datta_lab_to_nwb/markowitz_gillis_nature_2023/markowitz_gillis_nature_2023_metadata.yaml
Outdated
Show resolved
Hide resolved
src/datta_lab_to_nwb/markowitz_gillis_nature_2023/markowitz_gillis_nature_2023_metadata.yaml
Outdated
Show resolved
Hide resolved
This PR should now address all the best practice critical/violations/suggestions from
|
I also moved the example nwbfile to inside this github repo. I know it's generally better practice to keep large data files separate, but this one session is only ~3MB, and it seems handy to have a version-controlled example file for inspection. |
Please remove that and continue to share it outside the repo If email is too inconvenient, we can use either a shared Google Drive, Dropbox, or the 'catalystneuro-processing' S3 bucket (which I believe you have credentials to access?), or TBH at this point we are good to upload any draft files to the actual DANDI set Reason: The current size of the entire The only files we've ever made an exception for in that regards are NWB files that are on the order of single-double digit KB and so are practically indistinguishable from the text files they live next to With regards to your ideas for a CI - the action itself would handle data transfer from source to cache, which is fine because those logs are not version controlled and are even cleared automatically every couple of months Note to self: do not forget to squash this PR so that it gets purged from the history |
Ok, I removed the nwbfile, so this should be good to merge now. I will look into some of the alternative solutions we discussed (ex. CI streaming from DANDI) when I get a chance, but probably not until after 6/26/23.
Don't forget! |
Fixes #18